VenuReddy2103 commented on code in PR #6399:
URL: https://github.com/apache/hive/pull/6399#discussion_r3095182825
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/MarkCleanedFunction.java:
##########
@@ -50,6 +50,11 @@ public MarkCleanedFunction(CompactionInfo info) {
public Void execute(MultiDataSourceJdbcResource jdbcResource) throws
MetaException {
NamedParameterJdbcTemplate jdbcTemplate = jdbcResource.getJdbcTemplate();
MapSqlParameterSource param;
+ if (info.isSoftDelete()) {
+ // Remove compaction queue record and return
+ removeCompactionAndAbortRetryEntries(info, jdbcTemplate);
+ return null;
+ }
Review Comment:
done
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/MarkCleanedFunction.java:
##########
@@ -175,7 +180,7 @@ private void
removeCompactionAndAbortRetryEntries(CompactionInfo info, NamedPara
String deleteQuery = """
DELETE FROM "COMPACTION_QUEUE" WHERE "CQ_ID" = :id
""";
- if (!info.isAbortedTxnCleanup()) {
+ if (!info.isAbortedTxnCleanup() && !info.isSoftDelete()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
