abstractdog commented on code in PR #6366: URL: https://github.com/apache/hive/pull/6366#discussion_r3078685961
########## ql/src/test/queries/clientpositive/cast_decimal_vectorized.q: ########## @@ -0,0 +1,9 @@ +CREATE TABLE test_stats0 (e decimal(38,10)) stored as orc; +insert into test_stats0 (e) values (0.0); + +set hive.vectorized.execution.enabled=false; +select count(*) from test_stats0 where CAST(e as DECIMAL(15,1)) BETWEEN 100.0 AND 1000.0; + + +set hive.vectorized.execution.enabled=true; +select count(*) from test_stats0 where CAST(e as DECIMAL(15,1)) BETWEEN 100.0 AND 1000.0; Review Comment: thanks, I believe this exactly shows the expected behavior, which is that `FilterDecimalColumnBetween` is used, otherwise, the column vector produced by `CastDecimalToDecimal` (which is an instance of `DecimalColumnVector`) cannot be used from the parent expression `FilterDecimal64ColumnBetween` which expects a `LongColumnVector` (which represents the decimal64) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
