tanishq-chugh commented on code in PR #6366:
URL: https://github.com/apache/hive/pull/6366#discussion_r3080173012
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java:
##########
@@ -1717,6 +1717,10 @@ private boolean
checkExprNodeDescForDecimal64(ExprNodeDesc exprNodeDesc) throws
GenericUDF udf = ((ExprNodeGenericFuncDesc)
exprNodeDesc).getGenericUDF();
Class<?> udfClass = udf.getClass();
if (udf instanceof GenericUDFToDecimal) {
+ ExprNodeDesc child = exprNodeDesc.getChildren().get(0);
+ if (isDecimalFamily(child.getTypeString())) {
Review Comment:
@abstractdog My understanding of the same completely aligns with yours here.
I have added a javadoc for checkExprNodeDescForDecimal64() in this commit -
[e02bba3](https://github.com/apache/hive/pull/6366/commits/e02bba3ecabf096b02733adb748cc65dd91210f0)
Regarding the integer column part as well, you are absolutely right.
isDecimalFamily() returns false, and true is returned from the code point you
pointed out. Have added queries in the same qtest for the validation in commit
-
[73f664c](https://github.com/apache/hive/pull/6366/commits/73f664cb1b98e413ab19872c80732019803fc38b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
