abstractdog commented on code in PR #6376:
URL: https://github.com/apache/hive/pull/6376#discussion_r3079702778
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5670,7 +5670,9 @@ public static enum ConfVars {
HIVE_QUERY_RESULTS_CACHE_ENABLED("hive.query.results.cache.enabled", true,
"If the query results cache is enabled. This will keep results of
previously executed queries " +
"to be reused if the same query is executed again."),
-
+
HIVE_QUERY_RESULTS_SAFE_CACHE_WRITE_ENABLED("hive.query.results.safe.cache.write.enabled",
false,
+ "If the query results safe cache is enabled. This will safely write to
cache directory by first evaluating " +
+ "the cache entry is not overspilling the the cache directory
before writing it to cache directory "),
Review Comment:
agreed, I was about to comment the same, configuration should be clear about
the tradeoff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
