abstractdog commented on code in PR #6376:
URL: https://github.com/apache/hive/pull/6376#discussion_r3079741904
##########
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java:
##########
@@ -549,6 +578,39 @@ public boolean setEntryValid(CacheEntry cacheEntry,
FetchWork fetchWork) {
return false;
}
+ if (isSafeCacheWriteEnabled) {
+ Path resultDir = new Path(cacheDirPath, UUID.randomUUID().toString());
+ FileSystem cacheFs = resultDir.getFileSystem(conf);
+ cacheFs.mkdirs(resultDir);
+
+ Set<FileStatus> cacheFilesToFetch = new HashSet<>();
+ rwLock.writeLock().lock();
Review Comment:
I can see that in other places in this class, this is handled via a separate
variable:
```
Lock writeLock = rwLock.writeLock();
try{
writeLock.lock();
}
```
but that usage pattern is not consistent: feel free to pick one, and unify
all the lock usages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
