dengzhhu653 commented on code in PR #6267:
URL: https://github.com/apache/hive/pull/6267#discussion_r3083938782
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMiniClusters.java:
##########
@@ -554,23 +556,27 @@ private void setFsRelatedProperties(HiveConf conf,
boolean isLocalFs, FileSystem
// Create a fake fs root for local fs
Path localFsRoot = new Path(path, "localfs");
warehousePath = new Path(localFsRoot, "warehouse");
+ warehouseCatPath = new Path(localFsRoot, "catalog");
Review Comment:
I would like to raise my concern, personally I don't like to add a new
`metastore.warehouse.catalog.dir` as a default location for new
catalogs(non-default). this could bring some concerns IMO:
1. We use catalog to describe the source, we should at least get what/where
the catalog is before creating the new catalog, that suggests don't create the
catalog at will.
2. On creating the catalog, we create the default database as well, the
default database will stay at the old location even if we change the location
of the catalog, this might add some confusions on audit and bill consuming.
3. It's not a good experience to change the location after the catalog
created, as we should consider moving the managed tables, which could be
time/cost consuming.
So I would argue the location of catalog is immutable, we should check the
location of non-default catalog on creating it, this is not a big change I
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
