zhangbutao commented on code in PR #6267: URL: https://github.com/apache/hive/pull/6267#discussion_r3122250914
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CatalogUtil.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore; + +import com.google.common.base.Strings; + +public class CatalogUtil { + public static final String TYPE = "type"; + + // Supported Catalog types + public enum CatalogType { + HIVE, Review Comment: I don't quite understand what you mean. Could you explain it in more detail? Thank you. ########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: ########## @@ -694,6 +694,9 @@ private void rollbackTransactionToSavePoint(String savePoint) { @Override public void createCatalog(Catalog cat) throws MetaException { LOG.debug("Creating catalog {}", cat); + + ensureCatalogType(cat); Review Comment: `HMSHandler#create_catalog` may not be the only entry point for creating a catalog. So I think it would be more appropriate to place it in ObjectStore. What negative impacts do you think putting it here might have? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
