abstractdog commented on code in PR #6435: URL: https://github.com/apache/hive/pull/6435#discussion_r3100316889
########## packaging/src/docker/conf/tez-site.xml.template: ########## @@ -0,0 +1,74 @@ +<?xml version="1.0"?> +<?xml-stylesheet type="text/xsl" href="configuration.xsl"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<configuration> + <property> + <name>tez.am.mode.session</name> + <value>true</value> + </property> + <property> + <name>tez.am.framework.mode</name> + <value>${TEZ_FRAMEWORK_MODE}</value> + </property> + <property> + <name>tez.am.zookeeper.quorum</name> + <value>${TEZ_AM_ZOOKEEPER_QUORUM}</value> + </property> + <property> + <name>tez.am.registry.namespace</name> + <value>${TEZ_AM_REGISTRY_NAMESPACE}</value> + </property> + <property> + <name>tez.local.mode</name> + <value>false</value> + </property> + <property> + <name>tez.am.tez-ui.webservice.enable</name> + <value>false</value> + </property> + <!-- Tez AM should not timeout in ZK Mode --> + <property> + <name>tez.session.am.dag.submit.timeout.secs</name> + <value>-1</value> + </property> + <property> + <name>tez.ignore.lib.uris</name> + <value>true</value> + </property> + + <!-- + In standalone AM mode with LLAP, the task scheduler (LlapTaskSchedulerService) and task + communicator (LlapTaskCommunicator) are instantiated at AM startup from service_plugins_descriptor.json + on the classpath — not from the DAG payload as in YARN-submitted mode. These plugins read their + configuration from TezConfiguration, which is built exclusively from tez-site.xml on the classpath. + Hive-specific properties must therefore appear here so the AM can find LLAP daemons and connect + to them, even though they are conceptually Hive settings. + --> + <property> + <name>hive.zookeeper.quorum</name> + <value>${HIVE_ZOOKEEPER_QUORUM}</value> + </property> + <property> + <name>hive.llap.daemon.service.hosts</name> + <value>${HIVE_LLAP_DAEMON_SERVICE_HOSTS}</value> + </property> + <property> + <name>hive.llap.daemon.umbilical.port</name> + <value>33333</value> Review Comment: right, it works but needs a minor fix in LlapTaskCommunicator to handle the default properly: ``` - conf.get(HiveConf.ConfVars.LLAP_TASK_UMBILICAL_SERVER_PORT.varname) + HiveConf.getVar(conf, HiveConf.ConfVars.LLAP_TASK_UMBILICAL_SERVER_PORT) ``` otherwise I get: ``` tezam | 2026-04-17T12:23:28,727 INFO AbstractService - Service org.apache.hadoop.hive.llap.tezplugins.LlapTaskCommunicator failed in state STARTED tezam | java.lang.NullPointerException: Cannot invoke "String.split(String)" because the return value of "org.apache.hadoop.conf.Configuration.get(String)" is null tezam | at org.apache.hadoop.hive.llap.tezplugins.LlapTaskCommunicator.startRpcServer(LlapTaskCommunicator.java:261) tezam | at org.apache.tez.dag.app.TezTaskCommunicatorImpl.start(TezTaskCommunicatorImpl.java:140) tezam | at org.apache.hadoop.hive.llap.tezplugins.LlapTaskCommunicator.start(LlapTaskCommunicator.java:237) tezam | at org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41) tezam | at org.apache.hadoop.service.AbstractService.start(AbstractService.java:195) tezam | at org.apache.tez.dag.app.TaskCommunicatorManager.serviceStart(TaskCommunicatorManager.java:165) tezam | at org.apache.hadoop.service.AbstractService.start(AbstractService.java:195) tezam | at org.apache.tez.dag.app.DAGAppMaster$ServiceWithDependency.start(DAGAppMaster.java:1857) tezam | at org.apache.tez.dag.app.DAGAppMaster$ServiceThread.run(DAGAppMaster.java:1878) ``` good catch, fixing it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
