abstractdog commented on code in PR #6435:
URL: https://github.com/apache/hive/pull/6435#discussion_r3100429152
##########
packaging/src/docker/Dockerfile:
##########
@@ -67,19 +67,25 @@ RUN tar -xzv \
tar -xzv \
--exclude="apache-tez-$TEZ_VERSION-bin/share" \
-f /opt/apache-tez-$TEZ_VERSION-bin.tar.gz \
- -C /opt
+ -C /opt; \
+ mkdir -p /opt/tez-snapshot;
FROM eclipse-temurin:21-jdk-ubi9-minimal AS run
ARG UID=1000
ARG HADOOP_VERSION
ARG HIVE_VERSION
ARG TEZ_VERSION
+ARG TEZ_SNAPSHOT_VERSION=
+ARG
TEZ_SNAPSHOT_REPO_URL=https://repository.apache.org/content/repositories/snapshots
+
+# When snapshot jars are included, client version must match the snapshot
version.
+ENV TEZ_CLIENT_VERSION=${TEZ_SNAPSHOT_VERSION:-$TEZ_VERSION}
Review Comment:
this is needed or another config to disable client version check in TezAM,
otherwise we get:
```
tezam | 2026-04-17T12:50:58,952 INFO DAGAppMaster - Comparing
client version with AM version, clientVersion=Unknown, AMVersion=1.0.0-SNAPSHOT
tezam | 2026-04-17T12:50:58,953 ERROR DAGAppMaster - Incompatible
versions found, clientVersion=Unknown, AMVersion=1.0.0-SNAPSHOT
```
I'm fine with disabling the check:
https://github.com/apache/tez/blob/2ca44b4ba3839ff4c2c2ab2ec95e34d687f61c09/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java#L455-L476
in which case tez site xml has to contain:
```
<property>
<name>tez.am.disable.client-version-check</name>
<value>true</value>
</property>
```
it's fine to keep TEZ_CLIENT_VERSION, but the comment should be changed then
to:
```
Client version check is enabled by default in Tez AM, which is picked up
from TEZ_CLIENT_VERSION env var.
```
to reflect that this is not because of the optional snapshot override
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
