InvisibleProgrammer commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3118356658
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:
##########
@@ -2661,7 +2699,8 @@ public void testQueryTimeout() throws Exception {
+ " t2 on t1.under_col = t2.under_col");
fail("Expecting SQLTimeoutException");
} catch (SQLTimeoutException e) {
- assertNotNull(e);
+ assertTimeoutMessageShowsOneSecond(
Review Comment:
Honestly, I have doubts about the change itself so currently I'm trying to
reproduce the original issue.
The regex way of handling the set hive.query.timeout.seconds statement: in
general, set statements are modifying variables that Hive already loads into a
HiveConf object. The way of having a regex and checking every single statement
makes me suspicious. I don't really get why we should introduce a new way of
receiving set commands for one specific command. I more wonder about an other
approach, like letting the current value of the setting for the
statement/connection or getting a proper exception message at the right way
from TGetOperationStatusResp.
On overall, I don't want to accept that the only way to pass a hive config
value for a connection (or the effect of this value) is by checking all the
statements that the user executed one-by-one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
