ashniku commented on PR #6412: URL: https://github.com/apache/hive/pull/6412#issuecomment-4323839171
@InvisibleProgrammer Yes you are right, I was in the wrong direction. Did you get a chance to reproduce the issue ? I have changed ,the regex approach was the wrong abstraction. I've removed trackSessionQueryTimeoutIfSet and the Pattern from HiveStatement entirely. The resolution order is now: 1. TGetOperationStatusResp.errorMessage (primary) — SQLOperation sets "Query timed out after N seconds" with the actual value before cancel(TIMEDOUT), so the client simply passes this through. 2. Statement.setQueryTimeout(n) — JDBC standard, no change. URL-seeded value — applySessionQueryTimeoutFromJdbcUrl() reads hive.query.timeout.seconds from connParams.getHiveConfs() once at connect time (no SQL scanning at any point). 3. No SQL string is parsed per-statement on the client side anymore. The multi-statement test (testQueryTimeoutMessagePersistedAcrossStatements) still passes because the server message carries the correct duration. 4. Could you please check if this approach is the correct one. Could you please ping me @ [email protected]. Could you please help me suggets the pproach so that I can work on it as I am new to opensource project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
