deniskuzZ commented on code in PR #6358:
URL: https://github.com/apache/hive/pull/6358#discussion_r3130535279
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/formatter/TextDescTableFormatter.java:
##########
@@ -311,9 +311,11 @@ private void getStorageDescriptorInfo(StringBuilder
tableInfo, Table table, Stor
formatOutput("InputFormat:", storageDesc.getInputFormat(), tableInfo);
formatOutput("OutputFormat:", storageDesc.getOutputFormat(), tableInfo);
formatOutput("Compressed:", storageDesc.isCompressed() ? "Yes" : "No",
tableInfo);
+ // Show bucket columns for Native table or Iceberg table with CLUSTERED BY
(Hive-style bucketing)
+ boolean hasClusteredBy = storageDesc.getNumBuckets() > 0
+ && CollectionUtils.isNotEmpty(storageDesc.getBucketCols());
if (!table.isNonNative() || table.getStorageHandler() == null ||
- !table.getStorageHandler().supportsPartitionTransform()) {
- // The Iceberg partition transform already contains the bucketing
information, and these are not relevant there
+ !table.getStorageHandler().supportsPartitionTransform() ||
hasClusteredBy) {
Review Comment:
maybe refactor with !table..hasNonNativePartitionSupport ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
