deniskuzZ commented on code in PR #6358:
URL: https://github.com/apache/hive/pull/6358#discussion_r3189383753
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -178,6 +186,13 @@ static StorageDescriptor storageDescriptor(
}
storageDescriptor.setSerdeInfo(serDeInfo);
+
+ // Preserve Hive bucketing information if provided (for CLUSTERED BY
support)
+ if (CollectionUtils.isNotEmpty(bucketCols) && numBuckets > 0) {
Review Comment:
Does this specifically cover CLUSTERED BY (col1, col2) INTO Y BUCKETS ?
What happens in case of `PARTITIONED BY SPEC ( bucket(X, col1), bucket(Y,
col2))` ? numBuckets would be -1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
