deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3139279724


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java:
##########
@@ -124,8 +123,8 @@ public Partition(Table tbl, Map<String, String> partSpec, 
Path location) throws
 
   public static org.apache.hadoop.hive.metastore.api.Partition 
createMetaPartitionObject(
       Table tbl, Map<String, String> partSpec, Path location) throws 
HiveException {
-    List<String> pvals = new ArrayList<String>();
-    for (FieldSchema field : tbl.getPartCols()) {
+    List<String> pvals = new ArrayList<>();
+    for (FieldSchema field : tbl.getEffectivePartCols()) {

Review Comment:
   do we have tests for that. non-native use DummyPartition isn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to