deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3139327505


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -603,17 +610,38 @@ public List<FieldSchema> getPartCols() {
     return partKeys;
   }
 
+  /**
+   * Returns partition columns, consulting the storage handler for non-native 
tables (e.g. Iceberg)
+   * where partition columns are not stored in the metastore.
+   */
+  public List<FieldSchema> getEffectivePartCols() {
+    if (cachedPartCols != null) {
+      return cachedPartCols;
+    }
+    if (isTableTypeSet() && hasNonNativePartitionSupport()) {
+      cachedPartCols = getStorageHandler().getPartitionKeys(this);
+    } else {
+      cachedPartCols = getPartCols();
+    }
+    return cachedPartCols;
+  }
+
+  private boolean isTableTypeSet() {

Review Comment:
   why do we need this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to