deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3139367879
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/rewrite/sql/NativeAcidMultiInsertSqlGenerator.java:
##########
@@ -36,7 +36,7 @@ public NativeAcidMultiInsertSqlGenerator(Table table, String
targetTableFullName
@Override
public void appendAcidSelectColumns(Operation operation) {
queryStr.append("ROW__ID,");
- for (FieldSchema fieldSchema : targetTable.getPartCols()) {
+ for (FieldSchema fieldSchema : targetTable.getEffectivePartCols()) {
Review Comment:
it's definitely not needed in native
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/rewrite/sql/NativeAcidMultiInsertSqlGenerator.java:
##########
@@ -45,9 +45,9 @@ public void appendAcidSelectColumns(Operation operation) {
@Override
public List<String> getDeleteValues(Operation operation) {
- List<String> deleteValues = new ArrayList<>(1 +
targetTable.getPartCols().size());
+ List<String> deleteValues = new ArrayList<>(1 +
targetTable.getEffectivePartCols().size());
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
