deniskuzZ commented on PR #6454: URL: https://github.com/apache/hive/pull/6454#issuecomment-4326920772
> Sorry @deniskuzZ — misread your earlier "do we even need this?" as "remove it". Restored the external-warehouse `properties.put` in [ce92efc](https://github.com/apache/hive/commit/ce92efc6313954c190830a4eaf44e1a24264e063), and applied your `CatalogProperties.WAREHOUSE_LOCATION` suggestion to the warehouse line in the same commit. @1fanwang i meant do we need to call `setConf` at all, since we pass everything thought the properties? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
