deniskuzZ commented on PR #6454: URL: https://github.com/apache/hive/pull/6454#issuecomment-4327000682
> The one wrinkle on dropping `setConf` is `CLIENT_POOL_CACHE_KEYS = "conf:SERVLET_ID_KEY"` a few lines up — that tells HiveCatalog to read `SERVLET_ID_KEY` from Configuration when computing the per-test cache key, and without `setConf` HiveCatalog falls back to its default Configuration that doesn't have `SERVLET_ID_KEY` (so cache-key uniqueness breaks for the embedded tests). Leaning toward a separate follow-up JIRA for the `setConf` cleanup so this PR stays focused on [HIVE-29461](https://issues.apache.org/jira/browse/HIVE-29461) — let me know if you'd rather roll it in. Should we introduce single constructor for that. Something similar to HadoopCatalog: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java#L137-L140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
