InvisibleProgrammer commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3149926427
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:
##########
@@ -336,11 +374,46 @@ private void checkBadUrl(String url) throws SQLException {
* @throws SQLException
*/
public void testURLWithFetchSize() throws SQLException {
- Connection con = getConnection(testDbName + ";fetchSize=1234", "");
- Statement stmt = con.createStatement();
+ Connection connectionWithFetchSize = getConnection(testDbName +
";fetchSize=1234", "");
+ Statement stmt = connectionWithFetchSize.createStatement();
assertEquals(stmt.getFetchSize(), 1234);
stmt.close();
- con.close();
+ connectionWithFetchSize.close();
+ }
+
+ /**
+ * Same idea as {@link #testURLWithFetchSize}: drive session behavior from
the JDBC URL instead of
+ * only {@link Statement#setQueryTimeout(int)} or an explicit {@code SET}.
The timeout is supplied
+ * in the URL query ({@code ?hive_conf_list}) per the driver format
+ * {@code jdbc:hive2://.../db;sess?hive_conf#hive_var}.
+ * <p>
+ * HIVE-28265: {@link SQLTimeoutException#getMessage()} must reflect the
configured limit (1s),
Review Comment:
Please do not add exact ticket numbers into the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
