konstantinb commented on code in PR #6423: URL: https://github.com/apache/hive/pull/6423#discussion_r3169300925
########## ql/src/test/queries/clientpositive/cte_materialize.q: ########## @@ -0,0 +1,46 @@ +-- Test CTE materialization with both CBO enabled and disabled +-- Verifies DDLSemanticAnalyzerFactory is used for CTE materialization Review Comment: I agree that this is a bit too bold a statement - the test does indeed confirm that the NPE is fixed, but does not really validate classes used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
