konstantinb commented on PR #6423: URL: https://github.com/apache/hive/pull/6423#issuecomment-4356953029
@deniskuzZ, thank you for your feedback @kasakrisz, thank you very much for your prompt review. I have modified the Java test code side as suggested. I have also reduced the number of tests in the .q file to a single test that runs into an NPE on the current branch, with CBO **ON** by default and ALWAYS as the fallback logic. I believe this test provides value as long as the Non-CBO ReExec driver remains in the repository. The effort to remove all non-CBO execution paths is substantial and will likely take months, if not years. However, if you strongly feel that this .q file is unnecessary, I would be happy to delete it. Could you please let me know? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
