Aggarwal-Raghav commented on code in PR #6461:
URL: https://github.com/apache/hive/pull/6461#discussion_r3186330789
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java:
##########
@@ -574,8 +584,11 @@ public <T extends RESTResponse> T postForm(
}
@Override
- public void close() {
+ public void close() throws IOException {
// The caller is responsible for closing the underlying catalog backing
this REST catalog.
+ for (IcebergMetricsReporter reporter : metricsReporters) {
Review Comment:
In case if multiple reported are present and there is exception in closing 1
reporter, rest all will not be closed. Can we do something like this ?
https://github.com/apache/hive/blob/cff3c626e201f1ab6efb2fd58a28fa80ccd83104/ql/src/java/org/apache/hadoop/hive/ql/util/CloseableThreadLocal.java#L48-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
