Aggarwal-Raghav commented on code in PR #6461:
URL: https://github.com/apache/hive/pull/6461#discussion_r3186362052
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java:
##########
@@ -315,9 +323,11 @@ private RESTResponse renameTable(Object body) {
return null;
}
- private RESTResponse reportMetrics(Object body) {
- // nothing to do here other than checking that we're getting the correct
request
- castRequest(ReportMetricsRequest.class, body);
+ private RESTResponse reportMetrics(Map<String, String> vars, Object body) {
+ final var ident = identFromPathVars(vars);
Review Comment:
Just nitpicking, can we provide explicit type instead of `var` here? In
reflection code below that is totally understandable but what
`identFromPathVars` returns makes it difficult for me to infer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
