difin commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3192018948
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewAnalyzer.java:
##########
@@ -75,6 +75,17 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
List<String> partitionColumnNames =
children.containsKey(HiveParser.TOK_VIEWPARTCOLS) ?
getColumnNames((ASTNode)
children.remove(HiveParser.TOK_VIEWPARTCOLS).getChild(0)) : null;
+ ASTNode storageClause = null;
+ for (int storageTokenType : new int[] { HiveParser.TOK_STORAGEHANDLER,
HiveParser.TOK_TABLEFILEFORMAT,
+ HiveParser.TOK_FILEFORMAT_GENERIC }) {
+ ASTNode storageClauseCandidate = children.remove(storageTokenType);
+ if (storageClauseCandidate != null) {
+ storageClause = storageClauseCandidate;
+ break;
+ }
+ }
+ boolean icebergNativeView =
validateOptionalViewStorageClause(storageClause);
Review Comment:
Fixed - removed all Iceberg-specific code into HiveIcebergStorageHandler.
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewDesc.java:
##########
@@ -34,26 +34,38 @@
public class CreateViewDesc extends AbstractCreateViewDesc {
private static final long serialVersionUID = 1L;
+ /** HMS table property set when the view is declared with {@code STORED BY
ICEBERG} (native Iceberg view). */
+ public static final String ICEBERG_NATIVE_VIEW_PROPERTY =
"hive.iceberg.native.view";
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
