kasakrisz commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3226333265
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -1028,6 +1030,47 @@ default void setMergeTaskDeleteProperties(TableDesc
tableDesc) {
throw new UnsupportedOperationException("Storage handler does not support
getting custom delete merge schema.");
}
+ /**
+ * @return {@code true} if this handler may store CREATE VIEW text and
column metadata in an external catalog
+ * (native view) rather than only as a classic HMS virtual view.
+ */
+ default boolean supportsNativeViewCatalog() {
+ return false;
+ }
+
+ /**
+ * HMS table-level parameters to set on the metastore stub for a
native-catalog view (markers, etc.).
+ * Keys should be removed when {@linkplain
#clearNativeViewHmsTableProperties(Map)} is invoked for the same
+ * handler class recorded under {@link
Constants.NATIVE_VIEW_STORAGE_HANDLER_CLASS_PARAM}.
+ */
+ default Map<String, String> getNativeViewHmsTableProperties() {
Review Comment:
Can we call this simply `getViewProperties`? I would like to understand what
native and hms mean in this context.
AFAIK, a `native` object is one that doesn't have a storage handler. To me,
the word `native` in these method names is misleading. Could you please
elaborate on this a bit?"
getNativeViewHmsTableProperties
clearNativeViewHmsTableProperties
createOrReplaceNativeView
supportsNativeViewCatalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
