tanishq-chugh commented on code in PR #6443:
URL: https://github.com/apache/hive/pull/6443#discussion_r3219185057
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java:
##########
@@ -736,6 +729,25 @@ public ASTNode rewriteAST(ASTNode ast,
ColumnStatsAutoGatherContext context)
return rewrittenTree;
}
+ protected List<FieldSchema> getColumnsFromAst(ASTNode ast) throws
SemanticException {
+ List<FieldSchema> statsEligibleFS = null;
+ List<String> columnNames;
+ if (ast.getChildCount() == 2) {
+ statsEligibleFS = getStatsEligibleFieldSchemas(tbl);
+ columnNames = Utilities.getColumnNamesFromFieldSchema(statsEligibleFS);
+ } else{
+ columnNames = getExplicitColumnNamesFromAst(ast);
+ }
+
+ checkForPartitionColumns(columnNames,
Utilities.getColumnNamesFromFieldSchema(tbl.getPartitionKeys()));
+ validateSpecifiedColumnNames(columnNames);
+
+ if (statsEligibleFS != null) {
+ return statsEligibleFS;
+ }
+ return getFieldSchemasByColName(tbl, columnNames);
Review Comment:
Made this change in commit:
[4ca13d8](https://github.com/apache/hive/pull/6443/commits/4ca13d86634349416f0ae7d7479145d5356c0ccb)
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java:
##########
@@ -736,6 +729,25 @@ public ASTNode rewriteAST(ASTNode ast,
ColumnStatsAutoGatherContext context)
return rewrittenTree;
}
+ protected List<FieldSchema> getColumnsFromAst(ASTNode ast) throws
SemanticException {
+ List<FieldSchema> statsEligibleFS = null;
+ List<String> columnNames;
+ if (ast.getChildCount() == 2) {
+ statsEligibleFS = getStatsEligibleFieldSchemas(tbl);
+ columnNames = Utilities.getColumnNamesFromFieldSchema(statsEligibleFS);
+ } else{
Review Comment:
Fixed in commit:
[4ca13d8](https://github.com/apache/hive/pull/6443/commits/4ca13d86634349416f0ae7d7479145d5356c0ccb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
