tanishq-chugh commented on code in PR #6443:
URL: https://github.com/apache/hive/pull/6443#discussion_r3219707088
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -1428,12 +1427,16 @@ public void setTableName(String tableName) {
this.tableName = tableName;
}
- public List<String> getColName() {
- return colName;
+ public List<FieldSchema> getColumnSchemas() {
+ return columnSchemas;
+ }
+
+ public void setColumnSchemas(List<FieldSchema> columnSchemas) {
+ this.columnSchemas = columnSchemas;
}
- public void setColName(List<String> colName) {
- this.colName = colName;
+ public List<String> getColName() {
+ return columnSchemas == null ? null :
Utilities.getColumnNamesFromFieldSchema(columnSchemas);
Review Comment:
@abstractdog I see only one call of `AnalyzeRewriteContext#getColName()`
from
[TaskCompiler](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java#L675-L676)
before initialising `ColumnStatsDesc`, and no other calls which would lead to
multiple calls to `Utilities.getColumnNamesFromFieldSchema()`.
I am afraid i did not fully understand about how could this lead to issues
and rather removing getColName/getColType and introducing a new constructor in
ColumnStatsDesc using columnSchemas instead of colname/coltype which internally
calls same Utility funcs wouldn't be behaving the same? could you please
elaborate on this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
