rubenada commented on code in PR #6482:
URL: https://github.com/apache/hive/pull/6482#discussion_r3247429667
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -2930,7 +2980,8 @@ private RelNode genJoinLogicalPlan(QB qb, ASTNode
joinParseTree, Map<String, Rel
leftRel = aliasToRel.get(leftTableAlias);
} else if (SemanticAnalyzer.isJoinToken(left)) {
leftRel = genJoinLogicalPlan(qb, left, aliasToRel, outerNameToPosMap,
outerRR);
- } else if (left.getToken().getType() == HiveParser.TOK_LATERAL_VIEW) {
+ } else if (left.getToken().getType() == HiveParser.TOK_LATERAL_VIEW
Review Comment:
nit: perhaps we could refactor all these `type ==
HiveParser.TOK_LATERAL_VIEW || type == HiveParser.TOK_LATERAL_VIEW_OUTER` into
a single helper method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
