kasakrisz commented on code in PR #6482:
URL: https://github.com/apache/hive/pull/6482#discussion_r3280840222
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -1036,16 +1041,61 @@ boolean isCBOExecuted() {
}
@Override
- boolean isCBOSupportedLateralView(ASTNode lateralView) {
- // LATERAL VIEW OUTER not supported in CBO
- return lateralView.getToken().getType() !=
HiveParser.TOK_LATERAL_VIEW_OUTER;
+ boolean isCBOSupportedLateralView() {
+ // Both LATERAL VIEW and LATERAL VIEW OUTER are supported in CBO.
+ return !this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP);
Review Comment:
@thomasrebele
CBO return path is a different implementation of transforming the logical
plan to Hive operators. It skips the AST conversion and converts Calcite
operators directly to Hive operators. Maybe I'm missing something but I
haven't found any change regarding this conversion in this patch.
@soumyakanti3578
Does lateral views in general is supported in CBO return path?
If yes could you please implement the lateral view outer too. I assume it
would affect only 1-2 files and it would fit into the scope of this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
