InvisibleProgrammer commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3371329677
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##########
@@ -204,6 +222,18 @@ public void preCreateTable(CreateTableRequest request) {
setSortOrder(hmsTable, schema, tableProperties);
}
+ private void preCreateNativeIcebergLogicalView(CreateTableRequest request) {
+
+ org.apache.hadoop.hive.metastore.api.Table hmsTable = request.getTable();
Review Comment:
I'm not sure if this code is defensive enough: even if the code currently
can only run on a view it is not exists, those checks is pretty far from the
execution, not even in the same module.
A future modification can easily break this check and there is no way the
author of that future change will know about this execution path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
