difin commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3374174535


##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##########
@@ -161,6 +161,7 @@ public static void updateHmsTableForIcebergView(
         HiveOperationsBase.ICEBERG_VIEW_TYPE_VALUE.toUpperCase(Locale.ENGLISH),
         metadata.schema(),
         maxHiveTablePropertySize);
+    parameters.put(hive_metastoreConstants.META_TABLE_STORAGE, 
HIVE_ICEBERG_STORAGE_HANDLER);

Review Comment:
   Hive supports both Hive views as before and Iceberg views.
   Regular Hive view doesn't have storage handler set even when its base table 
is iceberg.
   See `iceberg_view.q` which tests creating both view types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to