ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3390795884
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java:
##########
@@ -107,7 +107,8 @@ private boolean shouldRewrite(ASTNode tree) {
*/
private static FieldSchemas getStatsEligibleFieldSchemas(Table tbl) {
List<FieldSchema> result = new ArrayList<>();
- for (FieldSchema col : tbl.getCols()) {
+ List<FieldSchema> colsToLookUp = tbl.hasNonNativePartitionSupport() ?
tbl.getAllCols() : tbl.getCols();
Review Comment:
this was added as for failing tests related to stats which I don't actually
remember.
( I think it makes sense as well since in general we compute stats for data
cols and for iceberg partition column is no different from data column so it
make sense to have it in eligible stats cols)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
