ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3394349214
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -595,26 +606,46 @@ public boolean equals(Object obj) {
&& Objects.equals(snapshotRef, other.snapshotRef);
}
+
+ /**
+ * Returns partition columns, consulting the storage handler for non-native
tables (e.g. Iceberg)
+ * where partition columns are not stored in the metastore.
+ */
public List<FieldSchema> getPartCols() {
- List<FieldSchema> partKeys = tTable.getPartitionKeys();
- if (partKeys == null) {
- partKeys = new ArrayList<>();
- tTable.setPartitionKeys(partKeys);
+ if (tablePartCols != null) {
+ return tablePartCols;
+ }
+ if (isTableTypeSet() && hasNonNativePartitionSupport()) {
+ List<FieldSchema> partCols = getStorageHandler().getPartitionKeys(this);
+ for (FieldSchema partCol : partCols) {
+ FieldSchema storageSchemaField =
getFieldSchemaByName(partCol.getName());
Review Comment:
how about then merging both the infos somewhat like that:
```
for (FieldSchema partCol : partCols) {
FieldSchema storageSchemaField =
getFieldSchemaByName(partCol.getName());
String userComment = storageSchemaField.getComment();
String mergedComment = userComment;
// logical view for iceberg uses HMS backed partition keys with no
transform info
if (!isView()) {
mergedComment = (userComment != null ? userComment : "") +
" (" + partCol.getComment() + ")";
}
partCol.setComment(mergedComment);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
