ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3441556192


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -728,8 +750,50 @@ private boolean isField(String col) {
     return false;
   }
 
+  private void  ensureColumnsIndexed() {

Review Comment:
   yes so we can keep it as the current behaviour then
   I think we should avoid extraction to Schema class in hive as 
   1.  these methods are for common usage for metadata object related to any 
kind of tables.
   2.  there are multiple schema classes in hive, and also they are not used 
extensively in multiple places in hive so to invoke these methods will become 
complex.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to