deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3442889736
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -728,8 +750,50 @@ private boolean isField(String col) {
return false;
}
+ private void ensureColumnsIndexed() {
Review Comment:
above comment is not fully addressed, @ramitg254 could you please
refactor/rename
lazyNameToField + indexFieldsByName()
````
private Map<String, TColumn> nameToField;
private Map<String, TColumn> lazyNameToField() {
if (nameToField == null) {
this.nameToField = indexFieldsByName();
}
return nameToField;
}
private Map<String, TColumn> indexFieldsByName() {
````
TColumn column = lazyNameToField().get(colName.toLowerCase());
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -728,8 +750,50 @@ private boolean isField(String col) {
return false;
}
+ private void ensureColumnsIndexed() {
Review Comment:
above comment is not fully addressed, @ramitg254 could you please
refactor/rename
````
private Map<String, TColumn> nameToField;
private Map<String, TColumn> lazyNameToField() {
if (nameToField == null) {
this.nameToField = indexFieldsByName();
}
return nameToField;
}
private Map<String, TColumn> indexFieldsByName() {
````
TColumn column = lazyNameToField().get(colName.toLowerCase());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
