wecharyu commented on code in PR #6464:
URL: https://github.com/apache/hive/pull/6464#discussion_r3585584259
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java:
##########
@@ -76,14 +84,58 @@ static String getMetastoreJdbcPasswd(Configuration conf)
throws SQLException {
}
}
- static String getMetastoreJdbcDriverUrl(Configuration conf) throws
SQLException {
+ static String getMetastoreJdbcDriverUrl(Configuration conf) {
+ if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_PROFILE_JDBC_EXECUTION)) {
+ return MetastoreDriver.getMetastoreDbUrl(conf);
+ }
return MetastoreConf.getVar(conf, MetastoreConf.ConfVars.CONNECT_URL_KEY);
}
+ static void addJdbcWrapperProperties(Configuration configuration, Properties
properties)
+ throws SQLException {
+ if (MetastoreConf.getBoolVar(configuration,
MetastoreConf.ConfVars.METASTORE_PROFILE_JDBC_EXECUTION)) {
+ try {
+ Configuration slimConf = new Configuration(false);
+ configuration.getPropsWithPrefix("metastore.jdbc.")
Review Comment:
nit: make `"metastore.jdbc."` as a constant string like
`METASTORE_CONF_PROPERTY`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
