dengzhhu653 commented on PR #6464: URL: https://github.com/apache/hive/pull/6464#issuecomment-4979654223
> @dengzhhu653 This is a nice feature for performance tracing. But can we consider a `ProfilingDataSource` decorator instead of a custom JDBC driver? There are some benefits: > > * Do not need convert jdbc related configures > * Do not need a custom Driver > * Do not need change the `XXCPDataSourceProvider` > > We have made such wrapper to enable `max_execution_time` in prod env, it works fine. cc @saihemanth-cloudera Nice catch! I removed the driver and use the delegate datasource to obtain the connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
