deniskuzZ commented on code in PR #4492:
URL: https://github.com/apache/hive/pull/4492#discussion_r3633695210
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java:
##########
@@ -1067,15 +961,15 @@ private boolean checkColEquality(List<List<String>>
grandParentColNames,
return false;
}
- private boolean hasOuterJoin(JoinOperator joinOp) throws SemanticException {
+ @VisibleForTesting
+ protected static boolean hasOuterJoin(JoinOperator joinOp) throws
SemanticException {
boolean hasOuter = false;
for (JoinCondDesc joinCondDesc : joinOp.getConf().getConds()) {
switch (joinCondDesc.getType()) {
case JoinDesc.INNER_JOIN:
case JoinDesc.LEFT_SEMI_JOIN:
case JoinDesc.ANTI_JOIN:
case JoinDesc.UNIQUE_JOIN:
Review Comment:
@houzhizhen, could we simplify switch and only check for outer join cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
