zabetak commented on code in PR #4492:
URL: https://github.com/apache/hive/pull/4492#discussion_r3913466365


##########
ql/src/test/results/clientpositive/llap/mapjoin_filter_on_outerjoin_tez.q.out:
##########
@@ -296,45 +303,39 @@ STAGE PLANS:
                       expressions: key (type: string), value (type: string)
                       outputColumnNames: _col0, _col1
                       Statistics: Num rows: 166 Data size: 29548 Basic stats: 
COMPLETE Column stats: COMPLETE
-                      Map Join Operator
-                        condition map:
-                             Right Outer Join 0 to 1
-                             Inner Join 1 to 2
-                        filter predicates:
-                          0 
-                          1 {(UDFToDouble(_col0) > 10.0D)}
-                          2 
-                        keys:
-                          0 _col0 (type: string)
-                          1 _col0 (type: string)
-                          2 _col0 (type: string)
-                        outputColumnNames: _col0, _col1, _col2, _col3, _col4, 
_col5
-                        input vertices:
-                          0 Map 1
-                          1 Reducer 2
-                        Statistics: Num rows: 8 Data size: 4224 Basic stats: 
COMPLETE Column stats: COMPLETE
-                        Reduce Output Operator
-                          key expressions: _col0 (type: string), _col2 (type: 
string), _col4 (type: string)
-                          null sort order: zzz
-                          sort order: +++
-                          Statistics: Num rows: 8 Data size: 4224 Basic stats: 
COMPLETE Column stats: COMPLETE
-                          value expressions: _col1 (type: string), _col3 
(type: string), _col5 (type: string)

Review Comment:
   I guess the whole purpose of this test was to verify something on Map outer 
joins. With the fix it seems that `Map Join` is removed. Is this an improvement?
   
   cc @ngsg who added this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to