saihemanth-cloudera commented on code in PR #6641: URL: https://github.com/apache/hive/pull/6641#discussion_r3753764607
########## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/IcebergAuthorizer.java: ########## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.iceberg.rest; + +import static org.apache.iceberg.hive.HiveCatalog.HMS_DB_OWNER; +import static org.apache.iceberg.hive.HiveCatalog.HMS_DB_OWNER_TYPE; +import static org.apache.iceberg.hive.HiveCatalog.HMS_TABLE_OWNER; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.function.Supplier; +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.api.PrincipalType; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; +import org.apache.hadoop.hive.ql.metadata.HiveException; +import org.apache.hadoop.hive.ql.metadata.HiveUtils; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAccessControlException; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthorizer; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthzContext; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthzPluginException; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveAuthzSessionContext; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveMetastoreClientFactoryImpl; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HiveOperationType; +import org.apache.hadoop.hive.ql.security.authorization.plugin.HivePrivilegeObject; +import org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizer; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.exceptions.ForbiddenException; +import org.apache.iceberg.hive.HiveHadoopUtil; +import org.apache.iceberg.rest.requests.CreateTableRequest; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Performs authorization checks for Iceberg REST Catalog operations that do not reach Hive Metastore. + * + * <p>Most catalog operations eventually call Hive Metastore and are authorized there. Some operations, such as + * stage-create, return metadata without creating a metastore object, so the corresponding metastore authorization + * hooks are not invoked. This class performs the required checks before those operations are processed. + */ +class IcebergAuthorizer { + private static final Logger LOG = LoggerFactory.getLogger(IcebergAuthorizer.class); + + @VisibleForTesting + final Supplier<HiveAuthorizer> authorizerSupplier; + + IcebergAuthorizer(Configuration conf) { + final var classes = MetastoreConf.getTrimmedStringsVar(conf, MetastoreConf.ConfVars.PRE_EVENT_LISTENERS); + if (classes.length == 0) { + LOG.info("No pre-event listeners configured, skipping authorization checks"); + this.authorizerSupplier = () -> null; + return; + } + if (Arrays.stream(classes).noneMatch(HiveMetaStoreAuthorizer.class.getName()::equals)) { + throw new IllegalArgumentException( + "HiveMetaStoreAuthorizer is required when pre-event listeners are configured, but %s is configured" + .formatted(Arrays.toString(classes))); + } + + this.authorizerSupplier = () -> { + try { + final var hiveConf = HiveConf.cloneConf(conf); + final var authorizerFactory = HiveUtils.getAuthorizerFactory(hiveConf, + HiveConf.ConfVars.HIVE_AUTHORIZATION_MANAGER); + + final var authenticator = HiveUtils.getAuthenticator(hiveConf, + HiveConf.ConfVars.HIVE_METASTORE_AUTHENTICATOR_MANAGER); + authenticator.setConf(hiveConf); + + final var authzContextBuilder = new HiveAuthzSessionContext.Builder(); + authzContextBuilder.setClientType(HiveAuthzSessionContext.CLIENT_TYPE.HIVEMETASTORE); + authzContextBuilder.setSessionString("IcebergRESTCatalog"); + return authorizerFactory.createHiveAuthorizer( + new HiveMetastoreClientFactoryImpl(hiveConf), hiveConf, authenticator, authzContextBuilder.build()); + } catch (HiveException e) { + throw new IllegalStateException("Failed to initialize Hive authorizer for Iceberg REST Catalog", e); + } + }; + } + + @VisibleForTesting + IcebergAuthorizer(Supplier<HiveAuthorizer> authorizerSupplier) { + this.authorizerSupplier = authorizerSupplier; + } + + /** + * Enforces authorization similar to [CreateTableEvent]. Checking the DFS_URI privilege for the location is critical; + * without it, Credential Vending becomes a ticket service that allows end users to access arbitrary locations. + * Checking DATABASE or TABLE_OR_VIEW privileges are nice to have. Without them, end users would notice missing + * privileges after writing data files. + * + * @param catalogName the Hive catalog name + * @param namespace the Iceberg namespace + * @param namespaceMetadata the Iceberg namespace metadata + * @param request the create table request + * @throws ForbiddenException if the user does not have the required privileges + * @throws IllegalStateException if the authorization plugin fails + */ + void validateStageCreateTable(String catalogName, Namespace namespace, Map<String, String> namespaceMetadata, + CreateTableRequest request) { + Preconditions.checkArgument(request.stageCreate(), "Only stage create requests are supported"); + Preconditions.checkArgument(namespace.levels().length == 1, "Hive does not support multi-level namespaces"); + var databaseName = namespace.level(0); + var authorizer = authorizerSupplier.get(); + if (authorizer == null) { + LOG.info("No pre-event listener is configured, skipping stage-create authorization"); + return; + } + + List<HivePrivilegeObject> inputs = request.location() == null + ? Collections.emptyList() + : Collections.singletonList(new HivePrivilegeObject(HivePrivilegeObject.HivePrivilegeObjectType.DFS_URI, + request.location())); + final String currentUser = HiveHadoopUtil.currentUser(); Review Comment: I prefer this `final String currentUser = UserGroupInformation.getCurrentUser().getUserName()` as UGI is the canonical Hadoop security identity source used by HMS/Ranger integrations and it also makes the identity source explicit at the security boundary. ########## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java: ########## @@ -116,8 +116,10 @@ private HttpServlet createServlet(Catalog catalog) { List<String> scopes = Collections.singletonList("catalog"); ServletSecurity security = new ServletSecurity(AuthType.fromString(authType), configuration, req -> scopes); String catalogName = MetastoreConf.getVar(configuration, ConfVars.CATALOG_DEFAULT); + IcebergAuthorizer icebergAuthorizer = new IcebergAuthorizer(configuration); List<IcebergMetricsReporter> reporters = createReporters(); - return security.proxy(new HMSCatalogServlet(new HMSCatalogAdapter(catalogName, catalog, reporters))); + return security.proxy(new HMSCatalogServlet(new HMSCatalogAdapter(catalogName, catalog, icebergAuthorizer, + reporters))); Review Comment: nit: newline is not required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
