okumin commented on code in PR #6641:
URL: https://github.com/apache/hive/pull/6641#discussion_r3755840673
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -116,8 +116,10 @@ private HttpServlet createServlet(Catalog catalog) {
List<String> scopes = Collections.singletonList("catalog");
ServletSecurity security = new
ServletSecurity(AuthType.fromString(authType), configuration, req -> scopes);
String catalogName = MetastoreConf.getVar(configuration,
ConfVars.CATALOG_DEFAULT);
+ IcebergAuthorizer icebergAuthorizer = new IcebergAuthorizer(configuration);
List<IcebergMetricsReporter> reporters = createReporters();
- return security.proxy(new HMSCatalogServlet(new
HMSCatalogAdapter(catalogName, catalog, reporters)));
+ return security.proxy(new HMSCatalogServlet(new
HMSCatalogAdapter(catalogName, catalog, icebergAuthorizer,
+ reporters)));
Review Comment:
The original line hit the 120-character rule. As the current line is highly
nested, I split the step into two lines.
https://github.com/apache/hive/pull/6641/changes/35c6915eb5004593bcdb774d45dbbb38384fd126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
