difin commented on code in PR #6655:
URL: https://github.com/apache/hive/pull/6655#discussion_r3762069298
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5536,6 +5536,14 @@ public static enum ConfVars {
+ ",s3.access-key-id"
+ ",s3.secret-access-key"
+ ",s3.session-token"
+ // Iceberg FileIO vended credential keys (GCS, ADLS, OSS)
+ + ",gcs.oauth2.token"
+ + ",adls.auth.shared-key.account.key"
+ + ",adls.sas-token."
+ + ",adls.token"
+ + ",client.access-key-id"
+ + ",client.access-key-secret"
+ + ",client.security-token"
Review Comment:
Done
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vended/AdlsVendedCredentialHadoopMapper.java:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.mr.hive.vended;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
+import org.apache.commons.lang3.StringUtils;
+
+/** Maps Iceberg ADLS FileIO properties to Hadoop ABFS connector keys. */
+enum AdlsVendedCredentialHadoopMapper implements VendedCredentialHadoopMapper {
+ INSTANCE;
+
+ static final String ADLS_SAS_TOKEN_PREFIX = "adls.sas-token.";
+ static final String ADLS_SAS_TOKEN_EXPIRES_AT_MS_PREFIX =
"adls.sas-token-expires-at-ms.";
+ static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
+
+ private static final String DFS_CORE_WINDOWS_NET_SUFFIX =
".dfs.core.windows.net";
+
+ @Override
+ public boolean supportsPrefix(String prefix) {
+ String scheme = VendedCredentialPrefixUtil.schemeFromPrefix(prefix);
+ return "abfs".equals(scheme) || "abfss".equals(scheme) ||
"wasb".equals(scheme) || "wasbs".equals(scheme);
+ }
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
