deniskuzZ commented on code in PR #6655: URL: https://github.com/apache/hive/pull/6655#discussion_r3782844239
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vended/OssVendedCredentialHadoopMapper.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive.vended; + +/** Maps Iceberg OSS FileIO properties to Hadoop Aliyun OSS filesystem keys. */ +enum OssVendedCredentialHadoopMapper implements VendedCredentialHadoopMapper { + INSTANCE; + + static final String CLIENT_ACCESS_KEY_ID = "client.access-key-id"; + static final String CLIENT_ACCESS_KEY_SECRET = "client.access-key-secret"; + static final String CLIENT_SECURITY_TOKEN = "client.security-token"; + static final String OSS_ENDPOINT = "oss.endpoint"; + + @Override + public boolean supportsPrefix(String prefix) { + return "oss".equals(VendedCredentialPrefixUtil.schemeFromPrefix(prefix)); + } + + @Override + public boolean supportsConfigKey(String icebergKey) { + return icebergKey.startsWith("client.") || icebergKey.startsWith("oss."); + } + + @Override + public String scopeFromPrefix(String prefix) { + return VendedCredentialPrefixUtil.scopeFromPrefix(prefix); + } + + @Override + public String toHadoopProperty(String bucket, String icebergKey) { + return switch (icebergKey) { + case CLIENT_ACCESS_KEY_ID -> "fs.oss.accessKeyId"; Review Comment: could be extracted to constants. please check if we don't have existing Property holders for that, similar to AwsClientProperties, S3FileIOProperties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
