rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3786028952
##########
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out:
##########
@@ -2301,10 +2307,10 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: srcpart
- filterExpr: UDFToDouble(hr) is not null (type: boolean)
+ filterExpr: (UDFToDouble(hr) * 2.0D) is not null (type:
boolean)
Review Comment:
Correct, but the current `RexSimplify#simplifyIsNotNull`
[code](https://github.com/apache/calcite/blob/caa051d22eca673dcd1671441e6bf2e0d9bcd718/core/src/main/java/org/apache/calcite/rex/RexSimplify.java#L1175)
will get that `isSafeExpression` of the multiplication is false (because one
of the operands is a non-lossless cast, hence not safe), so it shall return
```
if (!isSafe) {
return simplifiedResult; // null at that stage, hence not simplifiable
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
