thomasrebele commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3796105440
##########
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out:
##########
@@ -2301,10 +2307,10 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: srcpart
- filterExpr: UDFToDouble(hr) is not null (type: boolean)
+ filterExpr: (UDFToDouble(hr) * 2.0D) is not null (type:
boolean)
Review Comment:
Thanks for the context! Thinking more about it, an implementation of the
multiplication could change the nullability, if the result is outside of the
supported range of the type. It looks like Hive does an integer overflow, so
multiplication does not affect the nullability:
```
> select 9223372036854775807L*2, 32767S*2, 127Y*2;
+------+--------+------+
| _c0 | _c1 | _c2 |
+------+--------+------+
| -2 | 65534 | 254 |
+------+--------+------+
```
I've created
[CALCITE-7722](https://issues.apache.org/jira/browse/CALCITE-7722) to simplify
these kinds of expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
