rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3814350869
##########
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out:
##########
@@ -581,10 +581,10 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: srcpart
- filterExpr: CAST( ds AS DATE) is not null (type: boolean)
+ filterExpr: day(CAST( ds AS DATE)) is not null (type:
boolean)
Review Comment:
This would not come back with CALCITE-7722 per-se, since atm Calcite's
`SqlDatePartFunction`s (I assume Hive's `day`, as shown here, belongs to this
group) are not considered "safe", so the patch would not cover this case.
@zabetak I guess it makes sense to change it on Calcite side, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
