rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3814955866
##########
ql/src/test/results/clientpositive/llap/input8.q.out:
##########
@@ -36,14 +36,14 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: src1
- Statistics: Num rows: 25 Data size: 191 Basic stats:
COMPLETE Column stats: COMPLETE
+ Statistics: Num rows: 25 Data size: 2150 Basic stats:
COMPLETE Column stats: COMPLETE
Select Operator
- expressions: null (type: string), null (type: int), null
(type: double)
+ expressions: null (type: string),
UDFToInteger((UDFToDouble(key) - null)) (type: int), null (type: double)
Review Comment:
Indeed, SAFE_CAST is a totally different discussion, and not really relevant
for restoring (some of) the lost simplifications.
BTW, this particular one would NOT be restored by CALCITE-7722, since
Calcite considers that the cast is a non-lossless one (i.e. not "safe"), so
removing it could possibly hide a runtime exception (in case of an uncastable
value).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
