ramitg254 commented on code in PR #6703:
URL: https://github.com/apache/hive/pull/6703#discussion_r3843374888
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFGroupBatches.java:
##########
@@ -839,6 +887,12 @@ private void setRepeatingColumn(Object partitionKey,
VectorizedRowBatch targetBa
void preFinishPartition() throws HiveException {
int rows = size();
+ for (VectorPTFEvaluatorBase evaluator : evaluators) {
+ if (evaluator.needPartitionSize()) {
Review Comment:
added this check, because I didn't want to pollute the other evaluators with
dead variables population like partitionSize which aren't needed by them. how
about we should introduce these two interfaces so SRP won't be violated and we
will have clean implementation as well:
`public interface PartAwareEvaluator `
`public interface GroupAggregatedStreamingEvaluator `
WDYT? If it seems fine then I'll move ahead with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
