ramitg254 commented on code in PR #6703:
URL: https://github.com/apache/hive/pull/6703#discussion_r3843575706
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFGroupBatches.java:
##########
@@ -839,6 +887,12 @@ private void setRepeatingColumn(Object partitionKey,
VectorizedRowBatch targetBa
void preFinishPartition() throws HiveException {
int rows = size();
+ for (VectorPTFEvaluatorBase evaluator : evaluators) {
+ if (evaluator.needPartitionSize()) {
Review Comment:
I was thinking of removing `partitionSize` variable and it's `setter` from
base class and put it in interface PartAwareEvaluator so polluted variables
won't be present in other evaluators.
yes, but indeed with that we would have extra` N ops `which could be bad
tradeoff against that dead variables. Going ahead with directly calling
`setPartitionSize `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
