Aggarwal-Raghav commented on code in PR #6748:
URL: https://github.com/apache/hive/pull/6748#discussion_r3916036443
##########
beeline/pom.xml:
##########
@@ -133,12 +129,79 @@
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
+ <!-- kerby/kerberos auth chain pulled in transitively via hadoop-auth;
beeline
+ does not exercise hadoop-common's Kerberos/UGI code paths -->
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerb-core</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerb-util</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerby-config</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerb-crypto</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerby-pkix</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerby-asn1</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerby-util</artifactId>
+ </exclusion>
+ <!-- avro is only used by hadoop-common's optional
SequenceFile/serialization
+ helpers, not by Configuration/FileSystem/Path/IOUtils/ExitUtil -->
+ <exclusion>
+ <groupId>org.apache.avro</groupId>
+ <artifactId>avro</artifactId>
+ </exclusion>
+ <!-- ZooKeeper client (curator) is unused; beeline does not talk to ZK
+ through hadoop-common -->
+ <exclusion>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-client</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-recipes</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-framework</artifactId>
+ </exclusion>
+ <!-- htrace tracing hooks; not exercised by beeline's thin usage -->
+ <exclusion>
+ <groupId>org.apache.htrace</groupId>
+ <artifactId>htrace-core4</artifactId>
+ </exclusion>
+ <!-- jsch (SFTP/SSH) backs hadoop-common's SFTPFileSystem, which
beeline
+ never instantiates -->
+ <exclusion>
+ <groupId>com.jcraft</groupId>
+ <artifactId>jsch</artifactId>
+ </exclusion>
+ <!-- commons-net (FTP client) backs hadoop-common's FTPFileSystem,
unused -->
+ <exclusion>
+ <groupId>commons-net</groupId>
+ <artifactId>commons-net</artifactId>
+ </exclusion>
+ <!-- re2j is only used by hadoop-common's optional regex path matching
-->
+ <exclusion>
+ <groupId>com.google.re2j</groupId>
+ <artifactId>re2j</artifactId>
+ </exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>org.apache.thrift</groupId>
Review Comment:
Why this is excluded? there is direct dependency in beeline module
https://github.com/apache/hive/blob/bfe74f9b3f92188095d50cf103b86431f8aaa821/beeline/src/java/org/apache/hive/beeline/BeeLine.java#L110
##########
beeline/pom.xml:
##########
@@ -133,12 +129,79 @@
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
+ <!-- kerby/kerberos auth chain pulled in transitively via hadoop-auth;
beeline
+ does not exercise hadoop-common's Kerberos/UGI code paths -->
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerb-core</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.kerby</groupId>
+ <artifactId>kerb-util</artifactId>
Review Comment:
maybe
```
<exclusion>
<groupId>org.apache.kerby</groupId>
<artifactId>*</artifactId>
</exclusion>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
